On 15 March 2018 at 03:25, Daniel Stone <dan...@fooishbar.org> wrote: > Hi, > > On 14 March 2018 at 13:04, Rob Clark <robdcl...@gmail.com> wrote: >> I'm not sure everyone wants to be updating their dri3 in a forced >> march setting, this allows a nicer approach, esp when you want >> to build on distro that aren't brand new. > > I don't have that much of an opinion on whether the dependency should > be mandatory or not. I originally had #ifdefs and removed them when > reviewers asked me to. If people want to add them back, fine by me. > > That being said, these patches need changes, per comments below. One > thing missing entirely is making the version negotiation conditional: > when we call query_version for DRI3/Present, we need to make the > version we pass in conditional on whether or not we have new XCB. > Probably also wise to ifdef the multiplane_available variables, so > it's really obvious where any users are missing ifdefs.
I was trying to minimise the ifdeffery, we could minimise the present ones with #ifndef #define #endif blocks at the top, the dri3 one I think we just have to live with. > > I'm happy to test this tomorrow and submit a new version if that's > easier for people. Please do. Dave. _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
