On 10 March 2018 at 02:21, Bas Nieuwenhuizen <b...@basnieuwenhuizen.nl> wrote: > The vulkan API is not ideal as it does not allow us have a > shared limit. > > Feral needs 15+6 for one of their games, and I'm not a fan > of overcommitting the limits, so increase the number of > dynamic uniform buffers to 16. >
Reviewed-by: Dave Airlie <airl...@redhat.com> > CC: <mesa-sta...@lists.freedesktop.org> > CC: Alex Smith <asm...@feralinteractive.com> > --- > src/amd/vulkan/radv_device.c | 4 ++-- > src/amd/vulkan/radv_private.h | 4 +++- > 2 files changed, 5 insertions(+), 3 deletions(-) > > diff --git a/src/amd/vulkan/radv_device.c b/src/amd/vulkan/radv_device.c > index 7a11e08f97..0ed3e27c7b 100644 > --- a/src/amd/vulkan/radv_device.c > +++ b/src/amd/vulkan/radv_device.c > @@ -775,9 +775,9 @@ void radv_GetPhysicalDeviceProperties( > .maxPerStageResources = > max_descriptor_set_size, > .maxDescriptorSetSamplers = > max_descriptor_set_size, > .maxDescriptorSetUniformBuffers = > max_descriptor_set_size, > - .maxDescriptorSetUniformBuffersDynamic = > MAX_DYNAMIC_BUFFERS / 2, > + .maxDescriptorSetUniformBuffersDynamic = > MAX_DYNAMIC_UNIFORM_BUFFERS, > .maxDescriptorSetStorageBuffers = > max_descriptor_set_size, > - .maxDescriptorSetStorageBuffersDynamic = > MAX_DYNAMIC_BUFFERS / 2, > + .maxDescriptorSetStorageBuffersDynamic = > MAX_DYNAMIC_STORAGE_BUFFERS, > .maxDescriptorSetSampledImages = > max_descriptor_set_size, > .maxDescriptorSetStorageImages = > max_descriptor_set_size, > .maxDescriptorSetInputAttachments = > max_descriptor_set_size, > diff --git a/src/amd/vulkan/radv_private.h b/src/amd/vulkan/radv_private.h > index 0f8ddb2e10..439522585a 100644 > --- a/src/amd/vulkan/radv_private.h > +++ b/src/amd/vulkan/radv_private.h > @@ -87,7 +87,9 @@ typedef uint32_t xcb_window_t; > #define MAX_DISCARD_RECTANGLES 4 > #define MAX_PUSH_CONSTANTS_SIZE 128 > #define MAX_PUSH_DESCRIPTORS 32 > -#define MAX_DYNAMIC_BUFFERS 16 > +#define MAX_DYNAMIC_UNIFORM_BUFFERS 16 > +#define MAX_DYNAMIC_STORAGE_BUFFERS 8 > +#define MAX_DYNAMIC_BUFFERS (MAX_DYNAMIC_UNIFORM_BUFFERS + > MAX_DYNAMIC_STORAGE_BUFFERS) > #define MAX_SAMPLES_LOG2 4 > #define NUM_META_FS_KEYS 13 > #define RADV_MAX_DRM_DEVICES 8 > -- > 2.16.1 > > _______________________________________________ > mesa-dev mailing list > mesa-dev@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/mesa-dev _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev