On Wed, Feb 28, 2018 at 02:16:08PM +0100, Stefan Dirsch wrote: > On Wed, Feb 28, 2018 at 12:12:25PM +0100, Stefan Dirsch wrote: > > Patch by "Tomas Chvatal" <tchva...@suse.com> with modifications > > by "Michal Srb" <m...@suse.com> to not break python 2. > > > > https://bugzilla.suse.com/show_bug.cgi?id=1082303 > > > > v2: > > - open parse file in binary mode (default changed from binary to unicode > > text mode with python3) > > - make use of 'from __future__ import print_function', so semantics > > of print statements in python2 are closer to print functions in python3 > > > > https://lists.freedesktop.org/archives/mesa-dev/2018-February/187056.html > > Ok, guys. This patch is complete crap. Tested with > > python2/python3 ./egd_tables.py > > (meanwhile figured out, that the parse file itself needs to be added as second > argument) > > This happens if you try to upstream and revise a patch, that you didn't write > yourself (in a language you're not familiar with). Sigh. > > So please forget about this (not so nice) try.
Meanwhile I figured out that even the patch I initially sent was already broken. It generated lines like this: "b'NOP'\0" /* 0 */ "b'DEALLOC_STATE'\0" /* 4 */ instead of (python2) "NOP\0" /* 0 */ "DEALLOC_STATE\0" /* 4 */ OMG. Stefan Public Key available ------------------------------------------------------ Stefan Dirsch (Res. & Dev.) SUSE LINUX GmbH Tel: 0911-740 53 0 Maxfeldstraße 5 FAX: 0911-740 53 479 D-90409 Nürnberg http://www.suse.de Germany --------------------------------------------------------------- SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg) --------------------------------------------------------------- _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev