On Monday, February 26, 2018 11:02:08 PM PST Iago Toral Quiroga wrote: > In 16631ca30ea6 we fixed gen9 active components to account for padded > inputs in the URB, which we can have with SSO programs. To do that, > instead of going through the bitfield of inputs (which doesn't include > padding information), we compute the number of inputs from the size > of the URB entry. > > Unfortunately, there are some special inputs that are not stored in > the URB and that we also need to account for. These special inputs > are identified and handled during calculate_attr_overrides(), so this > patch modifies this function to return a value with the total number > of inputs, including the ones that are not stored in the URB, so we > can use that number to program the correct number of active components. > > This fixes a regression in a WebGL program that uses Point Sprite > functionality (specifically, VARYING_SLOT_PNTC). > > v2: > - Add 'Fixes' tag (Mark Janes) > - make no_vue_inputs int instead of uint32_t, and add const qualifier > to num_inputs variable (Ian) > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=105224 > Fixes: 16631ca30ea6 (i965/sbe: fix active components for SSO programs with > over 16 inputs) > --- > src/mesa/drivers/dri/i965/genX_state_upload.c | 31 > ++++++++++++++++++++------- > 1 file changed, 23 insertions(+), 8 deletions(-)
:( Thanks for fixing this, Iago. Reviewed-by: Kenneth Graunke <kenn...@whitecape.org>
signature.asc
Description: This is a digitally signed message part.
_______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
