Quoting Rob Clark (2018-02-28 12:54:28) > On Wed, Feb 28, 2018 at 3:25 PM, Matt Turner <matts...@gmail.com> wrote: > > I find this script *really* annoying. Getting Cc'd on a random sample of > > a series is doing it wrong. Cc lists of 14 people is doing it wrong. > > > > Let's start the negotiation with "delete this script" and see if anyone > > can come up with a way of making this not so stupid. > > tbh, if it were better about about not adding people to CC list just > because they had some commits around the effected code, I think that > would be better. Better populating of REVIEWERS and higher weight to > REVIEWERS over git-blame would help, I think. (It would be nice if it > wasn't a perl script, or at least that would make it easier for me to > fix that..) > > As far as being CC'd on part of a patchset vs whole patchset, I'm not > really sure how to do that w/ git's cc-cmd. I admit it would be nice > if it at least CC'd everyone on the cover letter for context, although > for a patchset that touched a lot of areas I think I'd prefer just to > be CC'd on cover letter plus individual patches. I guess if there was > a way for letting get_reviewers script see the whole patchset upfront, > then inventing a way to get individual preferences about being cc'd on > whole patchset vs cover letters and individual patches would be an > option. > > I do still like the general concept, to make it easier for the right > people to be CC'd on a patch, especially for drive-by submitters. > > BR, > -R >
What problem is this script trying to solve? Getting someone to look at patches? Figuring out who's code you're fixing? Having someone generally knowledgeable about a specific area of mesa look at your code? I don't think this script really does a good job at any of those. The last can be solved better by just looking at the REVIEWERS file I think (I'm not opposed to a script that just looks at the REVIEWERS file). I don't think that the second problem is generally scriptable, and the first (if it's a problem) is a culture problem and can't be solved by technical means. Dylan
signature.asc
Description: signature
_______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
