On Sat, 11 Feb 2012 12:48:03 -0800, Kenneth Graunke <kenn...@whitecape.org>
wrote:
> On 02/09/2012 09:42 PM, Eric Anholt wrote:
> > It turns out the same messages work on gen7, we were just being paranoid.
> >
> > Fixes the penumbra shadows mode of Lightsmark since the register
> > allocation fix.
> > ---
> > src/mesa/drivers/dri/i965/brw_fs_reg_allocate.cpp | 2 --
> > 1 files changed, 0 insertions(+), 2 deletions(-)
> >
> > diff --git a/src/mesa/drivers/dri/i965/brw_fs_reg_allocate.cpp
> > b/src/mesa/drivers/dri/i965/brw_fs_reg_allocate.cpp
> > index 0d1712e..7da1418 100644
> > --- a/src/mesa/drivers/dri/i965/brw_fs_reg_allocate.cpp
> > +++ b/src/mesa/drivers/dri/i965/brw_fs_reg_allocate.cpp
> > @@ -236,8 +236,6 @@ fs_visitor::assign_regs()
> >
> > if (reg == -1) {
> > fail("no register to spill\n");
> > - } else if (intel->gen>= 7) {
> > - fail("no spilling support on gen7 yet\n");
> > } else if (c->dispatch_width == 16) {
> > fail("no spilling support on 16-wide yet\n");
> > } else {
>
> Hmm. You're right...that should work fine.
>
> There were a number of reasons I hadn't implemented spilling:
> - Wrong data port caches
> - g112-127 weren't reserved for use as MRFS, so we already lost
> - I thought we had to use the new scratch read/write messages.
>
> I fixed the first one, you fixed the second, and the third is just a
> nicety. So this sounds good.Incidentally, I did play around with the scratch read message, but didn't quite get it working.
pgplibP5lUbay.pgp
Description: PGP signature
_______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
