On Tue, Feb 6, 2018 at 12:05 AM, Ilia Mirkin <imir...@alum.mit.edu> wrote: > On Mon, Feb 5, 2018 at 6:42 AM, Ilia Mirkin <imir...@alum.mit.edu> wrote: >> On Mon, Feb 5, 2018 at 6:24 AM, Daniel Stone <dan...@fooishbar.org> wrote: >>> Hi Ilia, >>> >>> On 4 February 2018 at 19:09, Ilia Mirkin <imir...@alum.mit.edu> wrote: >>>> One might have split this up into multiple patches, but it's just very >>>> repetitive and similar code. >>> >>> You probably want to add this into gbm_to_dri_image_formats[] inside >>> src/gbm/backends/dri/gbm_dri.c, so Wayland compositors running on KMS >>> and xf86-video-modesetting can also use these modes. >>> >>> Grepping for XRGB210 inside src/egl/drivers/dri2/platform_wayland.c >>> would also show the fairly obvious points to add it there. >> >> I thought I covered all the places where this was done, but obviously >> not. Perhaps in my euphoria of getting glxgears displaying the correct >> colors I decided I was done. >> >> I'll do another passthrough, and definitely hit that file explicitly. > > So I've been looking at platform_wayland and platform_x11, and it's > not totally clear to me how to make it all work. I'm stuck with e.g. > > dri2_wl_create_window_surface > dri3_create_image_khr_pixmap > > and others, wrt how to determine whether I should pick a XBGR or XRGB > format. I suspect that more information has to be stored somewhere. > Perhaps the _EGLConfig? Even that wouldn't cover everything though. > This is all quite foreign to me, and I'm not sure how it's supposed to > all fit together. Perhaps it can be left until later?
To sum up the IRC discussion and other series -- (a) Daniel wrote and pushed the support for most of EGL. Any remaining bits can be added as needed. (b) Daniel acked this series, provided that I remove the stray vdpau change. Unless there's other feedback, I'm going to push this out. -ilia _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
