Reviewed-by: Juan A. Suarez <jasua...@igalia.com>
On Fri, 2018-01-26 at 12:10 +0100, Antia Puentes wrote: > This reverts commit 513c2263cbff45edb105c7b46e58f316e06746ab. > > _mesa_base_fbo_format_ is used to validate the internalformat > passed to RenderbufferStorage, which in the OpenGL 4.6 is said: > > "An INVALID_ENUM error is generated if internalformat is not one of the > color-renderable, depth-renderable, or stencil-renderable formats defined > in section 9.4." > > RGB9_E5 format is not renderable, as stated in the same specification > (Bug 9338). > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=104794 > > Cc: Juan A. Suarez Romero <jasua...@igalia.com> > Cc: Kenneth Graunke <kenn...@whitecape.org> > --- > src/mesa/main/fbobject.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/src/mesa/main/fbobject.c b/src/mesa/main/fbobject.c > index c72204e11a0..d23916d1ad7 100644 > --- a/src/mesa/main/fbobject.c > +++ b/src/mesa/main/fbobject.c > @@ -1976,9 +1976,6 @@ _mesa_base_fbo_format(const struct gl_context *ctx, > GLenum internalFormat) > ctx->Extensions.ARB_texture_float) || > _mesa_is_gles3(ctx) /* EXT_color_buffer_float */ ) > ? GL_RGBA : 0; > - case GL_RGB9_E5: > - return (_mesa_is_desktop_gl(ctx) && > ctx->Extensions.EXT_texture_shared_exponent) > - ? GL_RGB: 0; > case GL_ALPHA16F_ARB: > case GL_ALPHA32F_ARB: > return ctx->API == API_OPENGL_COMPAT && _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
