On 2018-01-23 — 14:12, Francisco Jerez wrote: > Pierre Moreau <pierre.mor...@free.fr> writes: > > > Signed-off-by: Pierre Moreau <pierre.mor...@free.fr> > > --- > > src/gallium/state_trackers/clover/api/device.cpp | 5 +++++ > > 1 file changed, 5 insertions(+) > > > > diff --git a/src/gallium/state_trackers/clover/api/device.cpp > > b/src/gallium/state_trackers/clover/api/device.cpp > > index 4e274c5005..6bede21ca4 100644 > > --- a/src/gallium/state_trackers/clover/api/device.cpp > > +++ b/src/gallium/state_trackers/clover/api/device.cpp > > @@ -333,6 +333,11 @@ clGetDeviceInfo(cl_device_id d_dev, cl_device_info > > param, > > buf.as_string() = dev.supported_extensions(); > > break; > > > > + case CL_DEVICE_IL_VERSION_KHR: > > This should probably just throw CL_INVALID_VALUE if PIPE_SHADER_IR_SPIRV > is unsupported.
You are right, and I should change the check to test if the cl_khr_il_program extension is supported instead. And I’ll have in supported_extensions the code for checking whether the device supports SPIR-V, or an IR to which we can convert SPIR-V. > > > + buf.as_string() = > > + std::string(dev.supports_ir(PIPE_SHADER_IR_SPIRV) ? "SPIR-V_1.0" > > : ""); > > + break; > > + > > case CL_DEVICE_PLATFORM: > > buf.as_scalar<cl_platform_id>() = desc(dev.platform); > > break; > > -- > > 2.16.0
signature.asc
Description: PGP signature
_______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
