On 18 January 2018 at 18:09, Greg V <greg@unrelenting.technology> wrote: > On 01/18/2018 21:01, Emil Velikov wrote: >> >> On 31 December 2017 at 16:55, Greg V <greg@unrelenting.technology> wrote: >>> >>> (Needs CPU topology detection to actually work) >> >> IMHO it might be better to drop the patch, until its actually working. >> There's little point in building it if one cannot use it. >> >> What do you think? > > Yeah, I guess I only mentioned that in the cover letter or somewhere — I > have written that code and tested swr. > > Problem is, the topology is exposed as an XML string, so I used TinyXML2 to > parse it. > But I couldn't even figure out how to add that dependency to autotools, and > meson doesn't build swr yet. > Also not sure if that dependency is acceptable for Mesa. > (I guess it's technically possible to use Expat, which is already a > dependency, but ugh nope.)
My bad - I should have thoroughly read the cover letter first. Expat would be amazing (long term), although in the short term TinyXML2 would do. Handling autotools is trivial configure.ac: // go to the if building SWR hunk PKG_CHECK_MODULES([symbolic_name], [tinyxml2 >= $min_required version] Then use symbolic_name_CFLAGS and symbolic_name_LIBS in the appropriate places... Without seeing the patch cannot tell you where exactly, since SWR is a bit funky and produces five binaries. -Emil _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
