On Fri, 2017-12-15 at 23:04 +0100, Mario Kleiner wrote:
> Some clients may not like RGB10X2 and RGB10A2 fbconfigs and
> visuals. Add a new driconf option 'allow_rgb10_configs' to
> allow per application enable/disable.
>
> The option defaults to enabled.
>
> v2: Rename expose_rgb10_configs to allow_rgb10_configs,
> as suggested by Emil. Add comment to option parsing,
> to make sure it stays before the ->InitScreen().
>
> Signed-off-by: Mario Kleiner <mario.kleiner...@gmail.com>
> Reviewed-by: Tapani Pälli <tapani.pa...@intel.com>
> Reviewed-by: Marek Olšák <marek.ol...@amd.com>
> ---
> src/mesa/drivers/dri/common/dri_util.c | 12 ++++++++----
> src/util/xmlpool/t_options.h | 5 +++++
> 2 files changed, 13 insertions(+), 4 deletions(-)
>
> diff --git a/src/mesa/drivers/dri/common/dri_util.c
> b/src/mesa/drivers/dri/common/dri_util.c
> index d504751..d4fba0b 100644
> --- a/src/mesa/drivers/dri/common/dri_util.c
> +++ b/src/mesa/drivers/dri/common/dri_util.c
> @@ -55,6 +55,10 @@ const char __dri2ConfigOptions[] =
> DRI_CONF_SECTION_PERFORMANCE
> DRI_CONF_VBLANK_MODE(DRI_CONF_VBLANK_DEF_INTERVAL_1)
> DRI_CONF_SECTION_END
> +
> + DRI_CONF_SECTION_MISCELLANEOUS
> + DRI_CONF_ALLOW_RGB10_CONFIGS("true")
> + DRI_CONF_SECTION_END
> DRI_CONF_END;
>
This isn't exposing the driconf option for me with IVB HD4000. Adding
the option to the same section in
src/mesa/drivers/dri/i965/intel_screen.c did work though.Mind you having this default as true (which it does whether or not the option is available) is really bad here. On my LVDS display (which presumably isn't supporting 10bpc even if the chipset does, means by default my display colours are completely corrupted. What's more, the driconf option doesn't address Wayland compositors, for example GDM with Wayland doesn't respect the option but uses, I guess, a default config which happens to be 10bpc.
signature.asc
Description: This is a digitally signed message part
_______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
