On January 5, 2018 5:12:15 PM PST, Greg V <greg@unrelenting.technology> wrote:
>
>On 01/06/2018 01:06, Dylan Baker wrote:
>> Quoting Greg V (2017-12-31 08:55:22)
>>> +is_like_linux = host_machine.system() == 'linux' or
>host_machine.system().contains('bsd') # FIXME: illumos?
>> This won't cover dragonflybsd, which is just 'dragonfly'
>>
>> I think something like this would be better:
>> is_like_linux = ['openbsd', 'netbsd', 'freebsd', 'dragonfly',
>'linux'].contains(host_machine.system())
>Yeah, looks good to me.
>> I'd like to know what illumos returns, but I can't get it to run in
>VM. If you
>> have access to an illumos machine, getting the result of:
>> `python3 -c "import platform; print(platform.system().lower())"` so
>we can add
>> that to meson's support os values.
>I don't have a machine set up yet, but it's probably "sunos".
>There was some discussion in Meson about converting that to "solaris":
>https://github.com/mesonbuild/meson/issues/1578
I'll follow up in that bug for Solaris, so let's just leave the Todo for now.
>> As a nit, I'd prefer "system_is_linux_like" to just "is_like_linux"
>but I'm not
>> set on that like the first change.
>This can be bikeshedded for a long long time :) Maybe something like
>"system_has_kms_drm"?
I like that, it's more accurate.
With those changes you can put my rb on this.
Also, if you're interested I have a pull request again meson itself to fix a
bunch of BSD related issues.
_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
