On Fri, Jan 27, 2012 at 09:17:54AM -0800, Jose Fonseca wrote:
>
>
> ----- Original Message -----
> > On Mon, Jan 16, 2012 at 2:27 PM, Jose Fonseca <jfons...@vmware.com>
> > wrote:
> > > Tom,
> > >
> > > Looks good in principle!
> > >
> > > But I need to test this myself before I can be comfortable w/
> > > merging it into master.
> > >
> >
> > Hi Jose,
> >
> > Have you had a chance to test this out yet?
>
> Hi Tom,
>
> Sorry for dropping the ball. I just tried your branch now, and I'm hitting
> this segfault:
>
> #0 0x00007ffff46ab3f9 in lp_build_emit_fetch (bld_base=0x7fffffffb010,
> inst=0xb36760, src_op=0, chan_index=4294967295)
> at src/gallium/auxiliary/gallivm/lp_bld_tgsi.c:312
> 312 assert(reg->Register.Index <=
> bld_base->info->file_max[reg->Register.File]);
> (gdb) p bld_base->info
> $4 = (const struct tgsi_shader_info *) 0x0
> (gdb)
>
> Apart of fixing this, I need to properly understand how aos is being changed.
>
> Jose
>
Hi Jose,
Are you hitting that segfault with lp_build_tgsi_aos()? If so, the
attached patch should fix it. Please note though, that the aos code
has only been compile tested, since it isn't used anywhere in Mesa.
-Tom
>From dbf0698d6e07bae0ead5365d39097d6c7032fff6 Mon Sep 17 00:00:00 2001
From: Tom Stellard <thomas.stell...@amd.com>
Date: Fri, 27 Jan 2012 12:32:23 -0500
Subject: [PATCH] gallivm: lp_bld_tgsi_aos.c intialize tgsi_info
---
src/gallium/auxiliary/gallivm/lp_bld_tgsi_aos.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/src/gallium/auxiliary/gallivm/lp_bld_tgsi_aos.c
b/src/gallium/auxiliary/gallivm/lp_bld_tgsi_aos.c
index 26cfffe..e9a433d 100644
--- a/src/gallium/auxiliary/gallivm/lp_bld_tgsi_aos.c
+++ b/src/gallium/auxiliary/gallivm/lp_bld_tgsi_aos.c
@@ -1003,6 +1003,7 @@ lp_build_tgsi_aos(struct gallivm_state *gallivm,
bld.sampler = sampler;
bld.indirect_files = info->indirect_files;
bld.bld_base.emit_swizzle = swizzle_aos;
+ bld.bld_base.info = info;
bld.bld_base.emit_fetch_funcs[TGSI_FILE_CONSTANT] = emit_fetch_constant;
bld.bld_base.emit_fetch_funcs[TGSI_FILE_IMMEDIATE] = emit_fetch_immediate;
--
1.7.6
_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
