Do we have any tests at all that exercise this path? I don't know this code well enough to feel comfortable reviewing this (says everyone). :(
On 11/13/2017 09:04 AM, Emil Velikov wrote: > From: Emil Velikov <emil.veli...@collabora.com> > > There's little point in calling _eglGetNativePlatform() in > eglCopyBuffers. The platform return is identical to the one already > stored in our _EGLDisplay. > > Modulo subtle memory corruption of course. But in these cases returning > EGL_BAD_NATIVE_PIXMAP doesn't sound right. > > Signed-off-by: Emil Velikov <emil.veli...@collabora.com> > --- > src/egl/main/eglapi.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/src/egl/main/eglapi.c b/src/egl/main/eglapi.c > index c1bf5bbfe19..4aa93db829b 100644 > --- a/src/egl/main/eglapi.c > +++ b/src/egl/main/eglapi.c > @@ -1396,8 +1396,6 @@ eglCopyBuffers(EGLDisplay dpy, EGLSurface surface, > EGLNativePixmapType target) > native_pixmap_ptr = (void*) target; > > _EGL_CHECK_SURFACE(disp, surf, EGL_FALSE, drv); > - if (disp->Platform != _eglGetNativePlatform(disp->PlatformDisplay)) > - RETURN_EGL_ERROR(disp, EGL_BAD_NATIVE_PIXMAP, EGL_FALSE); > ret = drv->API.CopyBuffers(drv, disp, surf, native_pixmap_ptr); > > RETURN_EGL_EVAL(disp, ret); > _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
