Quoting Eric Engestrom (2017-12-04 07:38:04) > On Thursday, 2017-11-30 10:34:06 -0800, Dylan Baker wrote: > > Quoting Eric Engestrom (2017-11-29 07:44:08) > > > On Tuesday, 2017-11-28 15:30:21 -0800, Dylan Baker wrote: > > > > This series is the gallium media state trackers, the "nine" Direct3D > > > > state > > > > tracker, and an architectural change in the way gallium drivers are > > > > linked into > > > > the final targets. > > > > > > > > This architectural change results in a good deal of code savings, as > > > > well as > > > > ensuring that generated targets are generated before the targets that > > > > depend on > > > > them are built. It makes use of meson's `declare_dependency` construct > > > > to pass > > > > bundled arguments, and the result is somewhat similar to the way that > > > > autotools > > > > uses the Automake.inc files. > > > > > > > > The returning state trackers are the same as the v5 of the remaining > > > > drivers + media series, but now making use of the internal > > > > dependencies, and are > > > > joined by the D3D "nine" state tracker. > > > > > > > > Dylan Baker (14): > > > > meson: Combine gallium target subdirs > > > > meson: sort gallium drivers after winsys > > > > meson: define driver dependencies > > > > meson: use the driver dependencies for the gallium dri target > > > > > > Nice cleanups! ^ > > > I much prefer the code after your patches. > > > > > > I had a quick look, and it all looks fine to me; series is: > > > Acked-by: Eric Engestrom <eric.engest...@imgtec.com> > > > > > > (except the patches I actually reviewed, obviously :) > > > > Any comments on v2? I'm ready to start landing this stuff and get on to less > > interesting work like macOS :) > > Just looked through v2; I guess patch 12/15 (omx) will need changing; > not sure if you want to wait for the tizonia patches to land first, or > land 12/15 first and amend it when tizonia lands. > I'll leave that up to you.
Maybe change the choices to ['auto', 'bellagio', 'disabled'], for most people that wouldn't really change how they work, but it would make adding the tizonia patches easier? I'm ready to get this landed, so I think I'm going to land this now and we can cross the tizonia bridge when get there. > I'm not completely sure about patches 5/15 and 6/15, but they look > reasonable: > Acked-by: Eric Engestrom <eric.engest...@imgtec.com> > > Everything else in v2 is: > Reviewed-by: Eric Engestrom <eric.engest...@imgtec.com>
signature.asc
Description: signature
_______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
