On Thursday, November 30, 2017 4:42:47 PM PST Rafael Antognolli wrote:
> On CNL, we see multiple multisample failures on piglit tests. By
> emitting this extra state, though not documented in the bspec, those
> failures seem to go away.
>
> This workaround could be removed if we ever find out a better solution,
> but it should be good enough for now.
>
> Signed-off-by: Rafael Antognolli <rafael.antogno...@intel.com>
> Cc: Kenneth Graunke <kenn...@whitecape.org>
> ---
> src/mesa/drivers/dri/i965/genX_state_upload.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/src/mesa/drivers/dri/i965/genX_state_upload.c
> b/src/mesa/drivers/dri/i965/genX_state_upload.c
> index 8e500d3d285..bcfa3ee1bd8 100644
> --- a/src/mesa/drivers/dri/i965/genX_state_upload.c
> +++ b/src/mesa/drivers/dri/i965/genX_state_upload.c
> @@ -3298,7 +3298,8 @@ genX(upload_multisample_state)(struct brw_context *brw)
>
> static const struct brw_tracked_state genX(multisample_state) = {
> .dirty = {
> - .mesa = _NEW_MULTISAMPLE,
> + .mesa = _NEW_MULTISAMPLE |
> + (GEN_GEN == 10) ? _NEW_BUFFERS : 0,I can't find any information at all about why this would be required, but the other driver appears to re-emit 3DSTATE_MULTISAMPLE when changing render targets, so it's possible they haven't run into this issue. Let's go with this for now. (GEN_GEN == 10 ? _NEW_BUFFERS : 0), Reviewed-by: Kenneth Graunke <kenn...@whitecape.org> > .brw = BRW_NEW_BLORP | > BRW_NEW_CONTEXT | > BRW_NEW_NUM_SAMPLES, >
signature.asc
Description: This is a digitally signed message part.
_______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
