Am 26.11.2017 um 01:46 schrieb Matt Turner: >>> Sigh. Was supposed to be #warning. Strangely vim even syntax >>> highlights #warn. Committed a brown bag fix. >> >> As Jon was commenting, #warning is neither portable to MSVC 😕 >> >> AppVeyor error: >> https://ci.appveyor.com/project/mesa3d/mesa/build/6251 > > Bizarre. I've never known about that MSVC annoyance. We even use > #warning multiple other places in Gallium. >
I see some other places, but they all seem to be in places where windows has special handling anyway (so, when there's special handling for compilers or platforms, and then some maybe-not-really-safe default if nothing was recognized). I guess it may be a bit surprising #warning isn't a standard directive. Acoording to wikipedia at least gnu, intel and ibm support it, whereas with MSVC you need to use #pragma message instead... Roland _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
