I noticed this race condition too, this patch isn't correct though, since this
will add a radeonsi generated target unconditionally to the sources.
si_driinfo_h should be added to the gallium_dri_sources inside the `if
with_gallium_radeonsi` block.

Dylan

Quoting Juan A. Suarez Romero (2017-11-17 07:43:40)
> ---
>  src/gallium/targets/dri/meson.build | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/gallium/targets/dri/meson.build 
> b/src/gallium/targets/dri/meson.build
> index c591b75d037..bb056764b4c 100644
> --- a/src/gallium/targets/dri/meson.build
> +++ b/src/gallium/targets/dri/meson.build
> @@ -118,7 +118,7 @@ endif
>  
>  libgallium_dri = shared_library(
>    'gallium_dri',
> -  [files('target.c'), gallium_dri_sources],
> +  [files('target.c'), gallium_dri_sources, si_driinfo_h],
>    include_directories : [
>      inc_common, inc_util, inc_dri_common, inc_gallium_drivers,
>      inc_gallium_winsys, include_directories('../../state_trackers/dri'),
> -- 
> 2.13.6
> 
> _______________________________________________
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Attachment: signature.asc
Description: signature

_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Reply via email to