On 22.01.2012 16:46, Dave Airlie wrote:
2012/1/22 Christian König<deathsim...@vodafone.de>:
Sorry, but that looks really ugly and pretty much unmaintainable, cause you
constantly need to lookup the meaning of the values.

Also I haven't looked into the docs (but going to do so tomorrow), but I'm
pretty sure that those ranges aren't 100% correct.
It was the docs that the ranges came from, and we keep forgetting to
add things to these lookup functions.

Really? Where? I asked around when I coded this in the first place if it could be simplified by using ranges, but never got an clear answer on this topic.

When I now look into the AMD docs they mostly seems to use tables for opcode attributes, so I assumed that they are spread around in the opcode range.

If this isn't the case then this indeed seems to be an good idea.

Christian.
_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Reply via email to