Am 01.11.2017 7:06 nachm. schrieb "Wladimir J. van der Laan" < laa...@gmail.com>:
On Wed, Nov 01, 2017 at 06:38:21PM +0100, Christian Gmeiner wrote: > I would love to see a new format helper (util_format_is_astc(..) and not > even start thinking about adding a new format bit (ASTC_FORMAT). These formats are in a completely different space from the others, in the hardware (programmed through a different register), so IMO it makes sense to add a new format bit for it, just like for EXT_FORMAT. Relying on mesa's judgement on whether something is astc seems brittle. Sorry I do not share this option. Did you had a look at https://cgit.freedesktop.org/mesa/mesa/tree/src/gallium/auxiliary/util/u_ format.csv ? All astc formats are marked as those and why should we not trust mesa here? Such helper could look like: https://hastebin.com/jelisigife.m Do we need ctx->specs.tex_astc at all? We could simply do it like this in etnaviv_screen.c: if (util_format_is_astc(format)) supported = VIV_FEATURE(screen, chipMinorFeatures4, TEXTURE_ASTC); I am still on travel but will share you tomorrow evening how I think this should look like. Greets -- Christian
_______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
