On Wed, Nov 01, 2017 at 02:27:40PM +0100, Lucas Stach wrote: > Am Montag, den 30.10.2017, 17:14 +0100 schrieb Wladimir J. van der Laan: > > On Mon, Oct 30, 2017 at 02:21:07PM +0100, Lucas Stach wrote: > > > I would prefer the shorter expression (!cb->buffer && !cb->user_buffer) > > > here, which seems more consistent with the rest of the codebase. > > > > Well, I mimiced the style from other assertion in the function which > > compares > > explicitly with NULL. But ok, I'll update it some time. > > If you agree with my suggestion I can also just fix it up while > applying, but I'll leave the decision how you want to handle this up to > you.
Feel free to do so while applying - I don't mind how it's solved really, it's just useful to not have this crash :) Regards, Wladimir _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
