On 01/16/2012 01:30 PM, Brian Paul wrote:
The renderbuffer-cleanups-v2 branch removes all the old swrast GetRow/PutRow stuff. All swrast rendering is now done through renderbuffer mapping and the format_pack/unpack.c code.
Woo hoo! Thanks for tackling this! I've been slowly putting bandaids on some of the code, but it looks like you've saved me a ton of work!
The gl_renderbuffer type is smaller and cleaner now. Plus, a few more old driver hooks are removed.
I'm reviewing this code, and it looks good so far. However, it looks like it won't build at every commit. That's really important for bisecting. For example, I notice the patch that adds uses of gl_renderbuffer::Map appear before the patch that adds the field.
See also http://www.paranormal-entertainment.com/idr/blog/posts/2011-10-26T22:35:41Z-No_build_breaks/
There's room for more clean-ups and improvements in the swrast and non-gallium DRI drivers but I'm probably not going to do much with that since the objective of cleaning up core Mesa is done now. I'll probably merge this to master later this week if there's no concerns. I've tested with i965 and will try i945 later. -Brian _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
_______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
