Quoting Eric Anholt (2017-10-12 12:23:19) > Dylan Baker <dy...@pnwbakers.com> writes: > > > Rather than group dependencies in complex groups, use a flatter > > structure with split dependencies to avoid checking for the same > > dependencies twice. > > meson's going to be caching the dependency checks in the future, so I > wouldn't go out of your way to avoid checking twice, unless it cleans > things up. In fact, I hope we get to move some of the dependency > checking logic into the subdirs using them, for deps that aren't shared > between many pieces of the build. > > However, you've built a lot on top of this patch, and it doesn't hurt, > so I'm fine with it. A comment below, then r-b.
I saw that, and I'd like to make use of that feature once it lands, but for now
I'd rather leave it as-is. We're going to want/need to bump the meson version
dependency anyway for a few features and a lot of bug fixes around LLVM.
Dylan
>
> > @@ -484,10 +515,19 @@ else
> > dep_clock = cc.find_library('rt')
> > endif
> >
> > +# TODO: conditionalize libdrm requirement
>
> I think you can drop this comment now.
>
> > +dep_libdrm = dependency('libdrm', version : '>= 2.4.75',
> > + required : with_dri2 or with_dri3)
> > +if dep_libdrm.found()
> > + pre_args += '-DHAVE_LIBDRM'
> > +endif
signature.asc
Description: signature
_______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
