I sent one comment on patch #1. Apart from that, patches 1, 2, and 4-6 are:

Reviewed-by: Nicolai Hähnle <nicolai.haeh...@amd.com>


On 17.08.2017 18:10, Eric Anholt wrote:
Before we were doing RGBA4 on GLES3 only, but as of GLES2 2.0.22 it should
be RGBA4 as well.  Fixes DEQP
functional.state_query.rbo.renderbuffer_internal_format.

Tested-by: Matt Turner <matts...@gmail.com>
---
  src/mesa/main/renderbuffer.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/mesa/main/renderbuffer.c b/src/mesa/main/renderbuffer.c
index 5046f9d5f422..925001a76a38 100644
--- a/src/mesa/main/renderbuffer.c
+++ b/src/mesa/main/renderbuffer.c
@@ -66,7 +66,7 @@ _mesa_init_renderbuffer(struct gl_renderbuffer *rb, GLuint 
name)
      * specs. If the context is not current, we cannot determine the
      * API, so default to GL_RGBA.
      */
-   if (ctx && _mesa_is_gles3(ctx)) {
+   if (ctx && _mesa_is_gles(ctx)) {
        rb->InternalFormat = GL_RGBA4;
     } else {
        rb->InternalFormat = GL_RGBA;



--
Lerne, wie die Welt wirklich ist,
Aber vergiss niemals, wie sie sein sollte.
_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Reply via email to