On 4 October 2017 at 11:46, Daniel Stone <dan...@fooishbar.org> wrote:
> Hi Emil,
>
> On 27 September 2017 at 19:49, Emil Velikov <emil.l.veli...@gmail.com> wrote:
>> The callbacks may be called even when they are no longer valid.
>> Say, the user is dlclose(ing) libEGL while the buffers are being
>> destroyed.
>
> Series looks good to me, but if the user calls dlclose on EGL or
> whatever before the display/surface/buffers have all been destroyed,
> we're screwed anyway, since the authenticate callback will still point
> into oblivion. So the commit message probably needs some rework.
Indeed, the example is a bad one.
Nothing else comes to mind off the top of my head, so I'll just drop
the sentence for now.

> Regardless:
> Reviewed-by: Daniel Stone <dani...@collabora.com>
>

Thanks
Emil
_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Reply via email to