On 01/10/2012 09:06 AM, Dave Airlie wrote:

Something in Gallium is probably deciding that GL_DEPTH_COMPONENT is
invalid for a cubemap and marking it as incomplete.


Hmmm, I'm not sure what would be preventing cube textures in gallium or the
state tracker.

Something in Mesa is doing it,

texobj.c:_mesa_test_texobj_completeness

has a check for CUBE + DEPTH_COMPONENT on line 674.

How should we remove that with a GL3 version check?

My first inclination is:

if (ctx->VersionMajor < 3 && t->Image[face][i]->_BaseFormat == GL_DEPTH_COMPONENT) {

So we basically assume that depth cubes work if all the other GL3 features are available.

The other approach would be to define a (hidden) extension flag indicating support for depth cubes which GL3 would depend on.

I don't have a strong preference.

-Brian
_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Reply via email to