Le lundi 18 septembre 2017, 12:48:45 CEST Eric Engestrom a écrit : > On Monday, 2017-09-18 11:29:21 +0100, Emil Velikov wrote: > > From: Bernhard Rosenkraenzer <b...@lindev.ch> > > > > The current convinince function GetEnv feeds the results of getenv > > directly into std::string(). That is a bad idea, since the variable > > may be unset, thus we feed NULL into the C++ construct. > > > > The latter of which is not allowed and leads to a crash. > > > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=101832 > > Fixes: a25093de718 ("swr/rast: Implement JIT shader caching to disk") > > Cc: Tim Rowley <timothy.o.row...@intel.com> > > Cc: Laurent Carlier <lordhea...@gmail.com> > > Cc: Bernhard Rosenkraenzer <b...@lindev.ch> > > [Emil Velikov: make an actual commit from the misc diff] > > Signed-off-by: Emil Velikov <emil.veli...@collabora.com> > > Laurent just sent this to the ML an hour before you, but this commit > message is much better. > > Reviewed-by: Eric Engestrom <eric.engest...@imgtec.com> >
Yes, really better Reviewed-by: Laurent Carlier <lordhea...@gmail.com> -- Laurent Carlier http://www.archlinux.org
signature.asc
Description: This is a digitally signed message part.
_______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
