Hi Jason, thanks for the quick review! I agree with all your points and will update the series accordingly before pushing. Iago On Fri, 2017-09-15 at 17:11 -0700, Jason Ekstrand wrote: > I don't think we need patches 2 or 6 and the commit message from 2 > should probably go on 5. I left a comment on patch 4. Other than > that, 1, 3, 4, and 5 are > > Reviewed-by: Jason Ekstrand <ja...@jlekstrand.net> > > On Fri, Sep 15, 2017 at 3:02 AM, Iago Toral Quiroga <ito...@igalia.co > m> wrote: > > Jason, Ken: I think this series addresses all your feedback, let me > > know > > > > if you think I missed anything. > > > > > > > > Maybe you also prefer to squash some of the patches, let me know if > > that > > > > is the case. > > > > > > > > Iago Toral Quiroga (6): > > > > i965: rename BRW_NEW_FAST_CLEAR_COLOR to BRW_NEW_AUX_STATE > > > > i965: emit BRW_NEW_AUX_STATE when we allocate aux surfaces > > > > i965: emit BRW_NEW_AUX_STATE if we drop the aux surface > > > > i965: emit BRW_NEW_AUX_STATE when we change the fast clear value > > > > i965: emit BRW_NEW_AUX_STATE on aux state changes > > > > i965: emit BRW_NEW_AUX_STATE for textures without unresolved > > colors > > > > > > > > src/mesa/drivers/dri/i965/brw_blorp.c | 12 ++-------- > > > > src/mesa/drivers/dri/i965/brw_clear.c | 2 +- > > > > src/mesa/drivers/dri/i965/brw_context.h | 4 ++-- > > > > src/mesa/drivers/dri/i965/brw_gs_surface_state.c | 2 +- > > > > src/mesa/drivers/dri/i965/brw_state_upload.c | 2 +- > > > > src/mesa/drivers/dri/i965/brw_tcs_surface_state.c | 2 +- > > > > src/mesa/drivers/dri/i965/brw_tes_surface_state.c | 2 +- > > > > src/mesa/drivers/dri/i965/brw_vs_surface_state.c | 2 +- > > > > src/mesa/drivers/dri/i965/brw_wm_surface_state.c | 12 +++++----- > > > > src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 19 > > ++++++++++++--- > > > > src/mesa/drivers/dri/i965/intel_mipmap_tree.h | 28 > > +++++++++++++++++++++++ > > > > 11 files changed, 60 insertions(+), 27 deletions(-) > > > > > > > > -- > > > > 2.11.0 > > > > > > > > _______________________________________________ > > > > mesa-dev mailing list > > > > mesa-dev@lists.freedesktop.org > > > > https://lists.freedesktop.org/mailman/listinfo/mesa-dev > > > >
_______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
