I'm busy until Sunday, but I'll see if I can find the time to address Nicolai's comments on Sunday evening. I've addressed the build issues with the tests, and the comment about using util_vsnprintf, so it's getting there. I've also done some general polishing on comments, etc.
6. sep. 2017 23.00 skrev "Dieter Nützel" <die...@nuetzel-hh.de>: For the series: Tested-by: Dieter Nützel <die...@nuetzel-hh.de> But do NOT apply on current git any longer. With Nicolai's comments addressed new version underway? ;-) Dieter Am 29.08.2017 21:56, schrieb Thomas Helland: > This is a resend of the string buffer implementation and > related patches sent out back in May. I've done one more > change to the string buffer; using u_string.h for a compatible > vsnprintf version to reduce the code even more. I've not been > able to test this due to two build breakages (xmlpool and dri) > that I'm still trying to figure out of. But since I promised > to send these out this evening, I'm sending them untested. > I did test them thoroughly the last time around though, > so I believe it should be mostly good as long as I haven't > messed up the rebasing. I believe the string buffer part of > the series is the most important; the rest I've not really > gotten around to performance test much. > > Thomas Helland (7): > util: Add a string buffer implementation > util: Add tests for the string buffer > glsl: Change the parser to use the string buffer > glcpp: Use string_buffer for line continuation removal > glcpp: Avoid unnecessary call to strlen > port to gtest > fix test makefile > > Vladislav Egorov (1): > glcpp: Use Bloom filter before identifier search > > configure.ac | 2 + > src/compiler/glsl/glcpp/glcpp-lex.l | 3 +- > src/compiler/glsl/glcpp/glcpp-parse.y | 219 > ++++++++------------- > src/compiler/glsl/glcpp/glcpp.h | 18 +- > src/compiler/glsl/glcpp/pp.c | 64 ++++--- > src/util/Makefile.am | 3 +- > src/util/Makefile.sources | 2 + > src/util/string_buffer.c | 155 +++++++++++++++ > src/util/string_buffer.h | 87 +++++++++ > src/util/tests/string_buffer/Makefile.am | 38 ++++ > src/util/tests/string_buffer/append_and_print.cpp | 221 > ++++++++++++++++++++++ > 11 files changed, 633 insertions(+), 179 deletions(-) > create mode 100644 src/util/string_buffer.c > create mode 100644 src/util/string_buffer.h > create mode 100644 src/util/tests/string_buffer/Makefile.am > create mode 100644 src/util/tests/string_buffer/append_and_print.cpp >
_______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
