On Tue, Aug 29, 2017 at 6:15 AM, Emil Velikov <emil.l.veli...@gmail.com> wrote: > On 28 August 2017 at 22:57, Matt Turner <matts...@gmail.com> wrote: > >> - # Flags to help ensure that certain portions of the code -- and only >> those >> - # portions -- can be built with MSVC: >> - # - src/util, src/gallium/auxiliary, rc/gallium/drivers/llvmpipe, and >> - # - non-Linux/Posix OpenGL portions needs to build on MSVC 2013 (which >> - # supports most of C99) >> - # - the rest has no compiler compiler restrictions >> - MSVC2013_COMPAT_CFLAGS="-Werror=pointer-arith" >> - MSVC2013_COMPAT_CXXFLAGS="-Werror=pointer-arith" >> - > Can you please preserve the comment about the MSVC2013 flags? > With that the series is > Reviewed-by: Emil Velikov <emil.veli...@collabora.com>
Yes, thank you. > Mildly curious: > Did you pipe the series through ezbench for perf testing? > Wondering if the inline and fabsf -> babs changes made any noticeable impact. No, I cannot imagine it could cause any change. It's really just changing when a float -> double conversion happens. _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
