On Thursday, 2017-08-24 10:02:29 -0500, Rob Herring wrote: > On Thu, Aug 24, 2017 at 9:26 AM, Rob Herring <r...@kernel.org> wrote: > > On Thu, Aug 24, 2017 at 9:22 AM, Eric Engestrom > > <eric.engest...@imgtec.com> wrote: > >> Cc: Rob Herring <r...@kernel.org> > >> Signed-off-by: Eric Engestrom <eric.engest...@imgtec.com> > >> --- > >> This needs to land before [1], otherwise the latter will break android. > >> > >> [1] https://lists.freedesktop.org/archives/mesa-dev/2017-August/167428.html > >> > >> src/egl/drivers/dri2/platform_android.c | 1 + > >> 1 file changed, 1 insertion(+) > > > > For both patches: > > > > Reviewed-by: Rob Herring <r...@kernel.org> > > Actually, on further examination I think this isn't needed.
I pushed it a minute before your email: 688d866eca (I'm waiting on Emil (and maybe others?) to chime in on the khronos header change before I push it.) > egl_dri2.h includes system/window.h which in turn includes > native_window.h. I'll test out the EGL change without this. Personally, I like the include-what-you-use philosophy [1], so I'd rather have this include here anyway. [1] https://github.com/include-what-you-use/include-what-you-use/blob/master/docs/WhyIWYU.md _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
