On Thu, Jul 13, 2017 at 7:35 AM, Alejandro Piñeiro <apinhe...@igalia.com>
wrote:
> From: Jose Maria Casanova Crespo <jmcasan...@igalia.com>
>
> ---
> src/compiler/nir/nir.h | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/src/compiler/nir/nir.h b/src/compiler/nir/nir.h
> index 2ac5b1e..115ec1b 100644
> --- a/src/compiler/nir/nir.h
> +++ b/src/compiler/nir/nir.h
> @@ -107,6 +107,14 @@ typedef enum {
> } nir_variable_mode;
>
>
> +typedef enum {
> + nir_rounding_mode_undef = 0,
> + nir_rounding_mode_rtne = 1,
> + nir_rounding_mode_ru = 2,
> + nir_rounding_mode_rd = 3,
> + nir_rounding_mode_rtz = 4,
>
Could we have either better names or a comment on each as to what it
means. Better names could be:
nir_rounding_mode_nearest_even
nir_rounding_mode_up
nir_rounding_mode_down
nir_rounding_mode_towards_zero
Things like "rtne" are less typing but hard to read.
--Jason
> +} nir_rounding_mode;
> +
> typedef union {
> float f32[4];
> double f64[4];
> --
> 2.9.3
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
>
_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
