On 4 August 2017 at 11:03, Eric Engestrom <eric.engest...@imgtec.com> wrote: > On Thursday, 2017-08-03 19:29:36 +0100, Emil Velikov wrote: >> From: Emil Velikov <emil.veli...@collabora.com> >> >> The function can be called only when the type is EGL_WINDOW_BIT. >> Remove the unneeded switch statement. > > I take it we plan on never supporting pbuffers or pixmaps in platform_drm? > Pixmaps are explicitly forbidden, in the EGL platform gbm/wayland/android (yes there is one) spec. Pbuffers on the other hand are not mentioned at all in the ^^+x11 ones.
> If so, I'd rather fold dri2_drm_create_surface() into > dri2_drm_create_window_surface(), as `type` is meaningless now and should > be dropped, and without it the latter is an empty pass-through function. > (can/should be a separate commit, but please send both as a single series) > Ack. Will respin the lot, splitting the unrelated patches into separate series. > Reviewed-by: Eric Engestrom <eric.engest...@imgtec.com> > Thanks Emil _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
