On 4 August 2017 at 14:23, Tomasz Figa <tf...@chromium.org> wrote: > > If this needs so complicated series of checks, maybe it would make > more sense to just set enable_out_fence based on availability of the > capability at initialization time? > Either way is fine with me.
>> Did you drop it all together or changed to use some other surface? >> Would be nice to hear the reason why it was added - perhaps I'm >> missing something. > > We have to keep it, otherwise there would be no fence available at the > time of surface destruction, while, at least for Android, a fence can > be passed to window's cancelBuffer callback. > >> >> I think that we want a fence/fd for the new draw surface. Since >> otherwise one won't get created up until the first SwapBuffers call. > > I might be missing something, but wouldn't that insert a fence at the > beginning of command stream, before even doing anything? At least in > Android use cases, the only places we need the fence is in SwapBuffers > and DestroySurface and the fence should be inserted after all the > commands for rendering into given surface. > Thanks for the correction. You're absolutely correct in both cases. -Emil _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
