On Mon, Jul 17, 2017 at 8:24 AM, Daniel Stone <dan...@fooishbar.org> wrote:
> Hi, > > On 17 July 2017 at 15:39, Jason Ekstrand <ja...@jlekstrand.net> wrote: > > On Mon, Jul 17, 2017 at 2:24 AM, Daniel Stone <dan...@fooishbar.org> > wrote: > >> On 17 July 2017 at 01:48, Jason Ekstrand <ja...@jlekstrand.net> wrote: > >> > This commit splits the mapping in half. The modifier_infos table now > >> > only contains the modifier and the since_gen field. The tiling bits > >> > have been moved into a table in modifier_to_tiling as that's the only > >> > place it was ever used. The modifier_is_supported function now takes > a > >> > devinfo and does the since_gen check. > >> > >> Any reason to not just drop it the modifier <-> tiling map completely > >> and use isl_drm_modifier_get_info() + isl_tiling_to_i915_tiling()? I'm > >> all for more of this code being deleted! :) > > > > Because the commit message is wrong. It's the tiling_to_modifier > function > > into which it gets moved. :-) > > Sure. What I meant is that it seems like relatively low-hanging fruit > to do this all in ISL rather than open-coded. > Sure. Pulling tiling_to_modifier into ISL may not be a bad idea long-term.
_______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
