On 07/14/2017 05:45 AM, Emil Velikov wrote: > Hi gents, > > On 14 July 2017 at 02:57, Jason Ekstrand <ja...@jlekstrand.net> wrote: >> On Thu, Jul 13, 2017 at 6:38 PM, Ian Romanick <i...@freedesktop.org> wrote: > >>> >>> This will cause spirv_capability_to_string() to >>> happily return NULL pointers that none of the callers are prepared to >>> handle. >> > If this is an issue we'd want fixed in -stable, can I suggest a simple > NULL check.
I believe the NULL pointers would only be consumed by printf, which won't explode. I don't think a -stable fix is necessary. > Hmm the spirv_*_to_string helpers are used by vtn_warn() so there's no > big need for stable fix? > > Out of curiosity: is vtn_warn() meant to aid developers, or there's > something about it in the spirc/vulkan spec? > > Thanks > Emil > _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
