On 4 July 2017 at 16:47, Rafael Avila de Espindola <rafael.espind...@gmail.com> wrote: > Emil Velikov <emil.l.veli...@gmail.com> writes: > >> On 4 July 2017 at 16:04, Rafael Avila de Espindola >> <rafael.espind...@gmail.com> wrote: >>> Emil Velikov <emil.l.veli...@gmail.com> writes: >>> >>>> So the version is FOOgit-$SHA while the DSO uses, FOOsvn. At the same >>>> time at least 3.9.0/3.9.1 has broken llvm-config --libnames/libfiles, >>>> so we cannot rely on that. >>>> Doesn't seem like LLVM is giving us something robust to work with here. >>>> >>>> LLVM users/devs (Rafael), I would suggest up-streaming a patch which >>>> changes that toggle default value, for now. >>>> As LLVM does a few releases where it has a reliable way of determining >>>> the library name users can switch to it. >>>> >>>> How does this sound? >>> >>> I am not sure I understand why having the hash in the version causes >>> problems. >>> >> Because llvm-config --libnames/libfiles is unreliable ;-( Hence we use >> llvm-config --version to get the DSO name. > > OK, looks like that is the real bug that needs to be fixed. > > Is there a bug report? > I get the feeling you've missed part of my earlier reply. Please do so ;-)
libnames/libfiles were broken (fixed with [1]) for the released 3.9.0/3.9.1 at least. This is not something one can retroactively fix, me thinks. Although in general skim through git log [2] for all the breakages and feel free to reference which releases went out without the corresponding fix :-P Thanks Emil [1] https://github.com/llvm-mirror/llvm/commit/5340b5b3d970069aebf3dde49d8964583742e01a [2] https://github.com/llvm-mirror/llvm/commits/master/tools/llvm-config/llvm-config.cpp _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
