Hi Gert, A couple of trivial bits I've noticed in patches 2 and 3, but applicable overall.
- Unify if/return chains I've seen the following three examples, sometimes even right next to each other. if foo return f1; if bar return b1; return c1; if foo return f1; if bar return b1; else return c1; if foo return f1; else if bar return b1; return c1; Personal fav. is the first one (with blank lines in between), although regardless of the option do make sure code is consistent. - Braces for a single line statement in a if conditionals Some instances have, while others don't. I think most people prefer omitting them, although as long as you're consistent with surrounding code it's fine. - Tests still use STL? Am I looking at the right patches - shouldn't be a big deal either way. Regards, Emil _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
