Hi Gert, Welcome to Mesa, and apologies for chiming in so late.
Please don't use STL within core mesa code. While some places do use it, those are quite isolated and have specific role. For example: - st/clover - heavily templated, pure C++ - drivers/swr - as above - drivers/nouveau/codegen - mix of STL and local alternatives of STL - drivers/r600/sb - somewhat lightweight on STL usage. A couple of additional ideas: - where possible try to split patches even further. IIRC 2/3 adds some 2kloc, which may be hard to review properly. - do keep performance numbers within the commit summary. This way the details are preserved in git log for future references. Thanks Emil _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
