On Fri 26 May 2017, Jason Ekstrand wrote: > --- > src/mesa/drivers/dri/i965/brw_clear.c | 12 ++++++------ > src/mesa/drivers/dri/i965/brw_context.c | 7 ++++--- > src/mesa/drivers/dri/i965/brw_draw.c | 17 +++++++++-------- > src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 23 ++++++++++++++++++++++- > src/mesa/drivers/dri/i965/intel_mipmap_tree.h | 9 +++++++++ > 5 files changed, 50 insertions(+), 18 deletions(-)
Yes! For me, in this patch, the series finally clicked for me. Up until this patch, I've been cheerfully reviewing nice cleanups, nice refactors, nice simplifications. All those changes, however, felt like incremental improvements, each localized in concept. In this patch, I finally see how big of a global difference the series makes. Compared to the existing code (which was hairy spaghetti), reasoning about aux state and writing correct code to handle aux state transitions is now relatively effortless. Patch 23 is Reviewed-by: Chad Versace <chadvers...@chromium.org> _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
