On 05/06/17 23:54, Rafael Antognolli wrote:

realloc() does not initialize the newly added memory, unlike calloc(). So you
can't depend on those new pointers to be zero. It doesn't look like you depend
on that because you have the nfields variable anyways. But if you really don't
care about initializing it, you could simply do a realloc (there's no need for
the calloc part), since if ctx->group->fields is NULL it will act as a simple
malloc anyway.

With this fixed, this patch is:

Reviewed-by: Rafael Antognolli <rafael.antogno...@intel.com>

Thanks a bunch!


_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Reply via email to