On Wednesday, May 24, 2017 10:06:01 AM PDT Matt Turner wrote:
> On Wed, May 24, 2017 at 9:21 AM, Anuj Phogat <anuj.pho...@gmail.com> wrote:
> > This patch makes non-functional changes.
> >
> > V2: Rename IS_DWORD to IS_INTEGER_DWORD
> 
> 
> To be honest, I don't like IS_DWORD/IS_INTEGER_DWORD -- for the same
> reason Alejandro noted. It's not clear what it means exactly, and in
> most cases it would just be clearer to test against
> BRW_REGISTER_TYPE_D/UD.
> 
> I'd prefer we removed IS_DWORD.

Yeah, I'm not crazy about it either...I think just checking the types
is clearer.

Attachment: signature.asc
Description: This is a digitally signed message part.

_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Reply via email to