Jfyi: feel free to add Fixes tag as you see fit. We parse though and automatically nominate patches for -stable :-) On 19 May 2017 at 13:04, Rob Herring <r...@kernel.org> wrote: > On Fri, May 12, 2017 at 11:55 AM, Rob Herring <r...@kernel.org> wrote: >> There's still an error after my recent clean-up if LLVM is not patched to >> enable AMDGPU target: >> >> external/mesa3d/src/amd/common/ac_llvm_util.c:38:2: error: implicit >> declaration of function 'LLVMInitializeAMDGPUTargetInfo' is invalid in C99 >> [-Werror,-Wimplicit-function-declaration] >> LLVMInitializeAMDGPUTargetInfo(); >> ^ >> external/mesa3d/src/amd/common/ac_llvm_util.c:39:2: error: implicit >> declaration of function 'LLVMInitializeAMDGPUTarget' is invalid in C99 >> [-Werror,-Wimplicit-function-declaration] >> LLVMInitializeAMDGPUTarget(); >> ^ >> external/mesa3d/src/amd/common/ac_llvm_util.c:40:2: error: implicit >> declaration of function 'LLVMInitializeAMDGPUTargetMC' is invalid in C99 >> [-Werror,-Wimplicit-function-declaration] >> LLVMInitializeAMDGPUTargetMC(); >> ^ >> external/mesa3d/src/amd/common/ac_llvm_util.c:41:2: error: implicit >> declaration of function 'LLVMInitializeAMDGPUAsmPrinter' is invalid in C99 >> [-Werror,-Wimplicit-function-declaration] >> LLVMInitializeAMDGPUAsmPrinter(); >> ^ >> >> We need to drop libmesa_amd_common when LLVM is disabled, however there's >> still a dependency on include paths for ac_binary.h. So explicitly add the >> include path when LLVM is disabled. > > Emil, can you please apply. > Done, alongside the virgl patch. Might be worth getting a fd.o account [1] if you don't have one already.
Jfyi: feel free to add Fixes tag as you see fit. We parse though and automatically nominate patches for -stable :-) Thanks Emil [1] https://www.freedesktop.org/wiki/AccountRequests/ _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
