On 8 May 2017 at 11:52, Andres Gomez <ago...@igalia.com> wrote: > On Mon, 2017-05-08 at 10:56 +0100, Emil Velikov wrote: >> On 6 May 2017 at 15:09, Andres Gomez <ago...@igalia.com> wrote: >> > If an identified commit was having more than one fix, we would warn >> > about that and only treat the first. >> > >> > Now, we don't warn but treat all of them. >> > >> >> Having read through this a couple of times, I'm not sure I fully parse it. >> >> Are you saying that you want to flesh out all the commits when there's >> multiple Fixes tags? > > I'm not sure I'm understanding this previous sentence ... > What is the exact intent of the patch?
>> AFIACT that is not a wise idea, since a handful are corner cases like: >> - Fixes:\n $sha, Fixes: $piglit >> - Fixes: $sha.*Fixes: >> and others. > > I'm unsure I get which is the problem you see in those 2 examples. At > least, not if it is not a problem that was already happening with the > cases in which only one "Fixes" tag was found. > > Maybe you can elaborate on that? > The current WARNING approach was deliberately introduced. If commit has multiple tags that means: - It might need to be split - depending on how severe the issue is - something has gone wrong - typo, miss-nomination, etc and would require a few seconds more than the ordinary nominations. AFAICT your goal is to have the script produce a dummy list that one can copy/paste, but we do not want that here. -Emil _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
