On 05/05/2017 07:45 AM, Christian König wrote:
Am 04.05.2017 um 18:33 schrieb Emil Velikov:
From: Emil Velikov <emil.veli...@collabora.com>

Cc: Christian König <christian.koe...@amd.com>
Signed-off-by: Emil Velikov <emil.veli...@collabora.com>
---
UNTESTED.

Looks sane to me, but what bothers me a bit is that it is untested.

Leo do we (or QA) have a system somewhere where we could trow such things at and give them a try?

Yes, it got tested, and works.

For OMX, There is no presentation part to X back buffer, so DRI2/DRI3 is no difference on this perspective, what we only care about is to create a pipe context, that's why we even have the render node support for OMX as well.

This patch is:
Reviewed-and-Tested-by: Leo Liu <leo....@amd.com>

Leo

Setting up a box for transcode testing is always quite a hassle.

Christian.

---
  src/gallium/state_trackers/omx/entrypoint.c | 4 +++-
  1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/src/gallium/state_trackers/omx/entrypoint.c b/src/gallium/state_trackers/omx/entrypoint.c
index fa2074ad1b7..251cc7d65d5 100644
--- a/src/gallium/state_trackers/omx/entrypoint.c
+++ b/src/gallium/state_trackers/omx/entrypoint.c
@@ -103,7 +103,9 @@ struct vl_screen *omx_get_screen(void)
           if (!omx_display)
              goto error;
  -         omx_screen = vl_dri2_screen_create(omx_display, 0);
+         omx_screen = vl_dri3_screen_create(omx_display, 0);
+         if (!omx_screen)
+            omx_screen = vl_dri2_screen_create(omx_display, 0);
           if (!omx_screen) {
              XCloseDisplay(omx_display);
              goto error;



_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Reply via email to