Eh... I don't think this is needed but I don't really care too much. I guess there are only 2 gen8 plaforms so it makes some sense.
Would you mind adding one more patch to inline __emit_sf_state now that we don't need all the stupid? With that, all 4 would be Reviewed-by: Jason Ekstrand <ja...@jlekstrand.net> On Thu, May 4, 2017 at 12:07 PM, Kenneth Graunke <kenn...@whitecape.org> wrote: > To clarify "BDW Line Width" vs. "CHV Line Width". > --- > src/intel/genxml/gen8.xml | 2 +- > src/intel/vulkan/gen8_cmd_buffer.c | 2 +- > src/mesa/drivers/dri/i965/genX_state_upload.c | 2 +- > 3 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/src/intel/genxml/gen8.xml b/src/intel/genxml/gen8.xml > index 13924665601..ab13b4d7bd3 100644 > --- a/src/intel/genxml/gen8.xml > +++ b/src/intel/genxml/gen8.xml > @@ -2033,7 +2033,7 @@ > <field name="Statistics Enable" start="42" end="42" type="bool"/> > <field name="Viewport Transform Enable" start="33" end="33" > type="bool"/> > <field name="CHV Line Width" start="44" end="61" type="u11.7"/> > - <field name="Line Width" start="82" end="91" type="u3.7"/> > + <field name="BDW Line Width" start="82" end="91" type="u3.7"/> > <field name="Line End Cap Antialiasing Region Width" start="80" > end="81" type="uint"> > <value name="0.5 pixels" value="0"/> > <value name="1.0 pixels" value="1"/> > diff --git a/src/intel/vulkan/gen8_cmd_buffer.c > b/src/intel/vulkan/gen8_cmd_buffer.c > index 1522b36039f..875bef72be8 100644 > --- a/src/intel/vulkan/gen8_cmd_buffer.c > +++ b/src/intel/vulkan/gen8_cmd_buffer.c > @@ -115,7 +115,7 @@ __emit_sf_state(struct anv_cmd_buffer *cmd_buffer) > if (cmd_buffer->device->info.is_cherryview) > sf.CHVLineWidth = cmd_buffer->state.dynamic.line_width; > else > - sf.LineWidth = cmd_buffer->state.dynamic.line_width; > + sf.BDWLineWidth = cmd_buffer->state.dynamic.line_width; > #else > sf.LineWidth = cmd_buffer->state.dynamic.line_width, > #endif > diff --git a/src/mesa/drivers/dri/i965/genX_state_upload.c > b/src/mesa/drivers/dri/i965/genX_state_upload.c > index b6aa7c84d1d..caf4b555298 100644 > --- a/src/mesa/drivers/dri/i965/genX_state_upload.c > +++ b/src/mesa/drivers/dri/i965/genX_state_upload.c > @@ -1383,7 +1383,7 @@ genX(upload_sf)(struct brw_context *brw) > if (brw->is_cherryview) > sf.CHVLineWidth = brw_get_line_width_float(brw); > else > - sf.LineWidth = brw_get_line_width_float(brw); > + sf.BDWLineWidth = brw_get_line_width_float(brw); > #else > sf.LineWidth = brw_get_line_width_float(brw); > #endif > -- > 2.12.2 > > _______________________________________________ > mesa-dev mailing list > mesa-dev@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/mesa-dev >
_______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
