[Mesa-dev] [PATCH 2/2] radv: Use correct stage for ready bit.

[Bas Nieuwenhuizen]

Set the bit in the same stage as the timestamp, instead always at top of pipe.

Signed-off-by: Bas Nieuwenhuizen <ba...@google.com>
---
 src/amd/vulkan/radv_query.c | 33 ++++++++++++++++++++++++---------
 1 file changed, 24 insertions(+), 9 deletions(-)

diff --git a/src/amd/vulkan/radv_query.c b/src/amd/vulkan/radv_query.c
index 0991c267000..6d2325da47b 100644
--- a/src/amd/vulkan/radv_query.c
+++ b/src/amd/vulkan/radv_query.c
@@ -1194,7 +1194,7 @@ void radv_CmdWriteTimestamp(
 
        cmd_buffer->device->ws->cs_add_buffer(cs, pool->bo, 5);
 
-       MAYBE_UNUSED unsigned cdw_max = 
radeon_check_space(cmd_buffer->device->ws, cs, 12);
+       MAYBE_UNUSED unsigned cdw_max = 
radeon_check_space(cmd_buffer->device->ws, cs, 14);
 
        switch(pipelineStage) {
        case VK_PIPELINE_STAGE_TOP_OF_PIPE_BIT:
@@ -1206,6 +1206,14 @@ void radv_CmdWriteTimestamp(
                radeon_emit(cs, 0);
                radeon_emit(cs, query_va);
                radeon_emit(cs, query_va >> 32);
+
+               radeon_emit(cs, PKT3(PKT3_WRITE_DATA, 3, 0));
+               radeon_emit(cs, S_370_DST_SEL(V_370_MEM_ASYNC) |
+                               S_370_WR_CONFIRM(1) |
+                               S_370_ENGINE_SEL(V_370_ME));
+               radeon_emit(cs, avail_va);
+               radeon_emit(cs, avail_va >> 32);
+               radeon_emit(cs, 1);
                break;
        default:
                if (mec) {
@@ -1216,6 +1224,14 @@ void radv_CmdWriteTimestamp(
                        radeon_emit(cs, query_va >> 32);
                        radeon_emit(cs, 0);
                        radeon_emit(cs, 0);
+
+                       radeon_emit(cs, PKT3(PKT3_RELEASE_MEM, 5, 0));
+                       radeon_emit(cs, EVENT_TYPE(V_028A90_BOTTOM_OF_PIPE_TS) 
| EVENT_INDEX(5));
+                       radeon_emit(cs, 1 << 29);
+                       radeon_emit(cs, avail_va);
+                       radeon_emit(cs, avail_va >> 32);
+                       radeon_emit(cs, 1);
+                       radeon_emit(cs, 0);
                } else {
                        radeon_emit(cs, PKT3(PKT3_EVENT_WRITE_EOP, 4, 0));
                        radeon_emit(cs, EVENT_TYPE(V_028A90_BOTTOM_OF_PIPE_TS) 
| EVENT_INDEX(5));
@@ -1223,17 +1239,16 @@ void radv_CmdWriteTimestamp(
                        radeon_emit(cs, (3 << 29) | ((query_va >> 32) & 
0xFFFF));
                        radeon_emit(cs, 0);
                        radeon_emit(cs, 0);
+
+                       radeon_emit(cs, PKT3(PKT3_EVENT_WRITE_EOP, 4, 0));
+                       radeon_emit(cs, EVENT_TYPE(V_028A90_BOTTOM_OF_PIPE_TS) 
| EVENT_INDEX(5));
+                       radeon_emit(cs, avail_va);
+                       radeon_emit(cs, (1 << 29) | ((avail_va >> 32) & 
0xFFFF));
+                       radeon_emit(cs, 1);
+                       radeon_emit(cs, 0);
                }
                break;
        }
 
-       radeon_emit(cs, PKT3(PKT3_WRITE_DATA, 3, 0));
-       radeon_emit(cs, S_370_DST_SEL(mec ? V_370_MEM_ASYNC : 
V_370_MEMORY_SYNC) |
-                   S_370_WR_CONFIRM(1) |
-                   S_370_ENGINE_SEL(V_370_ME));
-       radeon_emit(cs, avail_va);
-       radeon_emit(cs, avail_va >> 32);
-       radeon_emit(cs, 1);
-
        assert(cmd_buffer->cs->cdw <= cdw_max);
 }
-- 
2.12.2

_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev