-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 12/05/2011 11:42 AM, Eric Anholt wrote: > Before, we had an uncached read of S8 to untile, then a RMW (so > uncached penalty) of the packed S8Z24 to store the value, then the > consumer would uncached read that once per pixel. If data was written > to the map, we would then have to uncached read the written data back > out and do the scatter to the tiled S8 buffer (also uncached access > penalties, since WC couldn't actually combine). So 3 or 5 uncached > accesses per pixel in the ROI (and we we were ignoring the ROI, so it > was the whole image). > > Now we get an uncached read of S8 to untile, and an uncached read of > Z. The consumer gets to do cached accesses. Then if data was > written, we do streaming Z writes (WC success), and scattered S8 > tiling writes (uncached penalty). So 2 or 3 uncached accesses per > pixel in the ROI. > > This should be a performance win, to the extent that anybody is doing > software accesses of packed depth/stencil buffers. > --- > src/mesa/drivers/dri/intel/intel_mipmap_tree.c | 243 > +++++++++++++----------- > src/mesa/drivers/dri/intel/intel_tex.h | 6 - > 2 files changed, 128 insertions(+), 121 deletions(-)
I like this improvement. Reviewed-by: Chad Versace <chad.vers...@linux.intel.com> -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQIcBAEBAgAGBQJO3mL9AAoJEAIvNt057x8iGSQP/RVq6z2mErdqxDd3lUGCDBpB 03WdTO7lbRe2lJb4lHSDiew/rJ4enFPMeJ5FAzxfVaJfLwMXfLW2OkjrMmxLLUZg WV4Lanae/80IE9wi9ksclnM+LywM/99SErdjFR5XvX5XqlEl3cNNGjJZPFdux1cn sr/ESIlws2ZH9nYdT/9eTXU9oFH7JRCHYR2URzkLu98ZCDmK20QI9yiGiR27p85N 3jGPcutxu+KEmzqkMhRSHn4JS3PP5DLV7NUMrWEww5uynB7yTfl92VUNaY99A+lz YXrdDCcUhycPn8mhOfbLZ1irFUNI8oX6aDM7WK9uCONl6ZZHYM2AcrQCOBE8XTKL xnw9A4eniHiSQLkNcdsg5uJ2LxfMepviBHVuic6ZEFvca7h3+nkmxCszJ2TdbHBG hdwpS7hU0BPyi4T1b06IenV45tgCQMJtwOf0r3+PVG/hyh41lM8+f6XX3NDYgNKq uJB0oIx4p7FG5E9uaaufox2Qlkh2o5BD0ky2XxKSIgEy6+ninoBZ28HuFYRet57j Ey/2arJA2hsomEX5UyZm/0mGOpqMdt/PeqcVXCsaS+eAdVxxPTTGF2qfaRzCievt 612vX8hnRQaL4pnU4pEtRmq7I1j+oL0fKgeBUe8SHVGXuOh2Tv3nIAy3CntvkmVX xJzpKtwu5IDnMh5diEP4 =fpGJ -----END PGP SIGNATURE----- _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
