On 04/19/2017 01:05 PM, Emil Velikov wrote: > From: Emil Velikov <emil.veli...@collabora.com> > > As pointed out by compiler > > ./llvm/codegen.hpp:52:22: error: ‘<::’ cannot begin a template-argument list > [-fpermissive] > ./llvm/codegen.hpp:52:22: note: ‘<:’ is an alternate spelling for ‘[’. Insert > whitespace between ‘<’ and ‘::’ > > Cc: Francisco Jerez <curroje...@riseup.net> > Cc: <mesa-sta...@lists.freedesktop.org> > Signed-off-by: Emil Velikov <emil.veli...@collabora.com> > --- > Supersedes: HACK: st/clover: automake: set -fpermissive for clover/llvm > > Commit message is a bit ... any suggestions will be appreciated. > --- > src/gallium/state_trackers/clover/llvm/codegen.hpp | 2 +- > src/gallium/state_trackers/clover/llvm/codegen/bitcode.cpp | 4 ++-- > src/gallium/state_trackers/clover/llvm/codegen/common.cpp | 6 +++--- > src/gallium/state_trackers/clover/llvm/codegen/native.cpp | 2 +- > src/gallium/state_trackers/clover/llvm/compat.hpp | 8 ++++---- > src/gallium/state_trackers/clover/llvm/metadata.hpp | 12 ++++++------ > 6 files changed, 17 insertions(+), 17 deletions(-) >
Commit message looks fine to me. If you still want to reword it, then remove mention of the compiler and say something along the lines of: "C++11 requires space between < and :: as <: is an alternate spelling for [ (see standard documents ... and ...)." I see you caught all the occurrences. Reviewed-by: Vedran Miletić <ved...@miletic.net> -- Vedran Miletić vedran.miletic.net _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
