On 03.12.2011 17:14, Vincent Lejeune wrote:
> glsl to tgsi pass now queries for reading output register cap
> from drivers. This made nvc0/nvfx complain about unknow
> PIPE_CAP that breaks piglit tests. This patch fix this.
> ---
> src/gallium/drivers/nv50/nv50_screen.c | 2 ++
> src/gallium/drivers/nvc0/nvc0_screen.c | 2 ++
> 2 files changed, 4 insertions(+), 0 deletions(-)
Please pay attention to *detail* the first time you submit a patch.
The commit message says nvc0/nvfx, but you don't touch nvfx but nv50.
All 3 should be updated.
There's no space after the ':'.
It's called PIPE_SHADER_CAP_OUTPUT>_READ<.
And the lengthy explanation is superfluous (in my opinion) and contains
spelling mistakes.
Attention. To. Detail. Is important. Also for the UBO patches.
> diff --git a/src/gallium/drivers/nv50/nv50_screen.c
> b/src/gallium/drivers/nv50/nv50_screen.c
> index 47eba85..1a788c7 100644
> --- a/src/gallium/drivers/nv50/nv50_screen.c
> +++ b/src/gallium/drivers/nv50/nv50_screen.c
> @@ -193,6 +193,8 @@ nv50_screen_get_shader_param(struct pipe_screen *pscreen,
> unsigned shader,
> return 0;
> case PIPE_SHADER_CAP_MAX_TEXTURE_SAMPLERS:
> return 32;
> + case PIPE_SHADER_CAP_OUTPUT_READ:
> + return 0;
> default:
> NOUVEAU_ERR("unknown PIPE_SHADER_CAP %d\n", param);
> return 0;
> diff --git a/src/gallium/drivers/nvc0/nvc0_screen.c
> b/src/gallium/drivers/nvc0/nvc0_screen.c
> index 38f918a..4a7a89f 100644
> --- a/src/gallium/drivers/nvc0/nvc0_screen.c
> +++ b/src/gallium/drivers/nvc0/nvc0_screen.c
> @@ -185,6 +185,8 @@ nvc0_screen_get_shader_param(struct pipe_screen *pscreen,
> unsigned shader,
> return 1;
> case PIPE_SHADER_CAP_MAX_TEXTURE_SAMPLERS:
> return 32;
> + case PIPE_SHADER_CAP_OUTPUT_READ:
> + return 0;
> default:
> NOUVEAU_ERR("unknown PIPE_SHADER_CAP %d\n", param);
> return 0;
_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
